Minor fixes and updates, ensure pins are better guarded#194
Merged
Conversation
This was
linked to
issues
May 22, 2026
Closed
Closed
Closed
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces additional guards and platform-aware updates for sensor configuration, warning reporting, and ADC handling within the PowerControlHub firmware.
Changes:
- Adds new sensor failure warning types and corresponding display strings.
- Adds PinGuard validation to sensor pin assignment commands and improves input-only pin handling on ESP32-S3.
- Introduces board-specific ADC resolution constants plus a setup-time
configureAdc()hook, and updates the voltage sensor ADC scaling.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| PowerControlHub/WarningType.h | Adds new warning bits (Voltage/Binary/Light/Water sensor failure) and display strings. |
| PowerControlHub/VoltageSensorHandler.h | Uses ADC_FULL_SCALE, adds disabled-pin guarding, and gates updates/MQTT on initialization. |
| PowerControlHub/SystemFunctions.h | Declares configureAdc() for boards supporting runtime ADC resolution selection. |
| PowerControlHub/SystemFunctions.cpp | Implements configureAdc() and changes safeJsonFloat() formatting. |
| PowerControlHub/SensorFactory.h | Adds disabled-pin checks that raise specific warnings and skip sensor instantiation. |
| PowerControlHub/SensorConfigCommandHandler.h | Adds PinGuard validation for the sensor pin assignment command (S4). |
| PowerControlHub/PowerControlHub.ino | Calls SystemFunctions::configureAdc() during setup(). |
| PowerControlHub/PinGuard.h | Adjusts ESP32-S3 input-only handling and treats input-only pins as safe for input uses. |
| PowerControlHub/BoardConfig.h | Adds ADC resolution/full-scale capability table and CONFIGURE_ADC define. |
| PowerControlHub.sln | Adds Docs/PinGuard.md to the solution. |
| Docs/PinGuard.md | Documents PinGuard behavior, coverage, and input-only handling (needs updates for S4 + bypass semantics). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
auto-merge was automatically disabled
May 22, 2026 10:38
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.