how does this even works? you create issue and you give solution and a pr? #14680
Replies: 4 comments
|
This is open source software, people can choose to open PRs for whatever issue they'd like. We will commit to reviewing them but won't commit to merging anything that does not meed the project's standards. |
|
Note however that if a maintainer opens an issue, or assigns it to themselves, they are probably planning on working on it, and will tend to prefer their PR to one from an outsider. Similarly, a PR with no issue, or with a community created issue that has not been validated by a maintainer, is unlikely to be accepted without additional interaction with the team. As Chris said, this is how open source software generally works. |
|
ok. this means I find bugs and open prs along with the issue? just like I do in the kubernetes codebase? |
|
Anyone can work on open issues, you don't need to be the author. The usual flow: pick an issue (the Opening an issue before the PR isn't strictly required for small fixes, but for anything non-trivial it's worth it. Maintainers can say "no, we don't want that" or "here's the right approach" before you burn a weekend on a patch that won't merge. That's why you see people file an issue and a PR together, they're just front-running the discussion. There's a CONTRIBUTING.md in the repo that covers the DCO sign-off and build setup, worth a skim before your first PR. — |
Uh oh!
There was an error while loading. Please reload this page.
or people can actually work on the open issues? no offense asking in public.
All reactions