Initial usable version #1
Conversation
| pngFile := path.Join(*dir, id) + ".png" | ||
|
|
||
| if _, e := os.Stat(pngFile); os.IsNotExist(e) { | ||
| // TODO(yi): Here we adopt an unlimted-size disk-based cache. We should |
There was a problem hiding this comment.
Another approach could be create a tmp file and and delete it after exec graphviz binary. Remove the tmp file and do something like following:
type entry struct {
md5 string
png []byte
}
var cache []entry
cache = append(cache, entry{md5,png})
if len(cache) > 100 {
cache = cache[1:]
}
not LRU cache but seems sufficient and simple enough. (linear search time but seems fine for this small program, not LRU but seems ok as well :))
This way will leave no trace on harddisk.
But the harddisk cache is fine as well.
There was a problem hiding this comment.
Does this mean a random-deletion cache other than LRU cache?
I love this idea. How about we implement it in a next PR?
There was a problem hiding this comment.
It will delete cache entry by earliest created one, but not necessarily Least Recent Used one (e.g., LRU cache will not delete earliest created one if it's recently used.)
Sure, LGTM!
|
LGTM! |
No description provided.