Skip to content

Fix SVG not rendering #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2017
Merged

Fix SVG not rendering #2

merged 2 commits into from
Jun 6, 2017

Conversation

@amitness
Copy link
Contributor

@amitness amitness commented Jun 6, 2017

GitHub no longer renders SVG directly from raw.github.com. It's treated as a text file now. I used rawgit.com to render the SVG in markdown.

@kabirbaidhya
Copy link
Owner

kabirbaidhya commented Jun 6, 2017

Merging this. Thanks.
BTW @amitness can you do rebase instead of merging, just to avoid extra merge commits like this Merge pull request #2 from amitness/dev. This will ensure cleaner commit logs.

@kabirbaidhya kabirbaidhya merged commit ac410ac into kabirbaidhya:master Jun 6, 2017
@amitness
Copy link
Contributor Author

amitness commented Jun 6, 2017

Sure. Thanks for the tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amitness @kabirbaidhya