Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
this teaches the bridge how to resolve
imsgfrom a few override points instead of assuming the binary only comes fromPATH.it now prefers:
-imsg-binflagIMSGBRIDGE_IMSG_BIN../imsg/bin/imsgwhen that existsimsgonPATHas the fallbackmake runalso passes the resolved local binary path so local bridge work will pick up a patched checkout automatically.why
history performance work currently lives in a local
imsgfork, not upstream. without an override, the daemon keeps using the installedimsgbinary and misses that faster history path.impact
local development can point the bridge at a patched
imsgbuild without editing code each time.production behavior stays the same unless an override is provided or the sibling checkout layout is present.
validation
go test ./...