refactor: extract_strings and extract_bytes_vec helpers in ember-protocol#100
Merged
refactor: extract_strings and extract_bytes_vec helpers in ember-protocol#100
Conversation
the .iter().map(extract_string).collect::<Result<Vec<_>, _>>()? chain appeared 9 times and the extract_bytes variant 2 times. added extract_strings() and extract_bytes_vec() — each call site drops from 3 lines to a single call.
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
the .iter().map(extract_string).collect::<Result<Vec<_>, _>>()? chain appeared 9 times and the extract_bytes variant 2 times. added extract_strings() and extract_bytes_vec() — each call site drops from 3 lines to a single call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
extract_strings(frames)andextract_bytes_vec(frames)helpers in command.rs.iter().map(extract_string).collect::<Result<Vec<_>, _>>()?and 2 occurrences of theextract_bytesvariantaffected parsers: parse_del, parse_exists, parse_mget, parse_unlink, parse_zrem, parse_hdel, parse_hmget, parse_sadd, parse_srem, parse_lpush, parse_rpush
what was tested
cargo clippy -p ember-protocol -- -D warnings— cleancargo test -p ember-protocol— all 297 tests pass (296 unit + 1 doc)