refactor: replace grpc pipeline dispatch with macro#128
Merged
Conversation
handle_pipeline_command had 57 identical match arms, each following the same pattern: call svc method, wrap response in PipelineResponse. replaced with a pipeline_dispatch! macro that generates all arms from a table of (Variant => method => Result) mappings. ~400 lines → ~80 lines, grouped by command category with comments.
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
handle_pipeline_command had 57 identical match arms, each following the same pattern: call svc method, wrap response in PipelineResponse. replaced with a pipeline_dispatch! macro that generates all arms from a table of (Variant => method => Result) mappings. ~400 lines → ~80 lines, grouped by command category with comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
handle_pipeline_commandwith apipeline_dispatch!macronet change: ~-311 lines
what was tested
cargo build -p ember-server --features grpc,vector,protobuf— clean buildcargo test -p ember-server --features grpc,vector,protobuf— all 43 tests passresult_large_errwarnings onvalidate_valueandvalidate_key; no new warnings introduced