Conversation
adds observability for memory limit rejections: - new `oom_rejections` counter on Keyspace, tracked incrementally - rate-limited warn! log on rejection (first + every 1000th) with used_bytes, limit, requested size, and total rejections - exported as `ember_oom_rejections_total` prometheus gauge - included in INFO stats output as `oom_rejections` - aggregated across shards in both metrics poller and INFO handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
operators currently have no visibility when memory limits reject writes. this adds rate-limited logging and a prometheus metric so ops teams can detect and alert on memory pressure.
oom_rejectionscounter onKeyspace, incremented whenenforce_memory_limitreturns falsewarn!log on first rejection + every 1000th (includes used bytes, limit, requested size)ember_oom_rejections_totalprometheus gauge, polled alongside existing keyspace statsoom_rejectionsfield in INFO stats outputwhat was tested
KeyspaceStatsstruct initialization updated in all three construction sites (keyspace, connection INFO, metrics poller)design considerations
Keyspace(same asevicted_totalandexpired_total) for consistency