fix: update safety_margin test for ENTRY_OVERHEAD 104#293
Merged
Conversation
adjust max_memory from 116 to 120 to match the new entry size (1 + 3 + 104 = 108 bytes, effective limit = 120 * 90% = 108).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
follow-up to #292 — the
safety_margin_rejects_near_raw_limittest hardcodedmax_memory: Some(116)based on the oldENTRY_OVERHEADof 100. with the bump to 104, one entry is now 108 bytes and the effective limit (116 * 90% = 104) no longer matches. updated tomax_memory: Some(120)so effective limit = 108.what was tested
cargo test -p emberkv-core --lib— all 507 tests pass.