fix: launch readiness — auth docs, healthcheck, metrics, info fields#310
Merged
fix: launch readiness — auth docs, healthcheck, metrics, info fields#310
Conversation
…pc keepalive - update SECURITY.md to reflect current auth capabilities (requirepass, ACL, TLS/mTLS) and add a per-ip rate limiting delegation note - add --healthcheck flag: syncs TCP ping to the configured RESP port, exits 0/1 — makes docker-compose healthcheck work - add keyspace_hits/keyspace_misses counters to KeyspaceStats; tracked on every get() call in keyspace::string - expose hits/misses in INFO stats section and as prometheus gauges (ember_keyspace_hits_total, ember_keyspace_misses_total) - fill in missing INFO fields: tcp_port, hz, config_file in server section; aof_last_bgrewrite_status and rdb_last_save_time in persistence section - configure gRPC keepalive (30s interval, 10s timeout, 60s tcp) on both server paths to clean up idle connections
This was referenced Feb 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
closes the pre-preview gaps identified in the launch readiness audit. all changes are documentation corrections, missing instrumentation, or operational hygiene — no behavior changes on the hot path.
what was changed
SECURITY.md — replaced the stale "no authentication" line with the actual current capabilities:
--requirepass, ACL per-user control, and TLS/mTLS. added a new section documenting that per-ip rate limiting is delegated to a reverse proxy/firewall.--healthcheckflag —ember-server --healthchecknow works. it opens a TCP connection to the configured RESP port, sendsPING, and exits 0/1 depending on whether it gets+PONG\r\nback. this makes the existing docker-compose healthcheck block functional.keyspace hits/misses — added
keyspace_hitsandkeyspace_missesu64 counters toKeyspaceStats, incremented on everyget()call. exposed in:INFO statsaskeyspace_hits/keyspace_misses(redis-compatible field names)ember_keyspace_hits_total/ember_keyspace_misses_totalINFO completeness — filled in fields expected by redis-compatible monitoring tools (datadog, redis_exporter, grafana dashboards):
tcp_port,hz,config_fileaof_last_bgrewrite_status,rdb_last_save_timegRPC keepalive — both tonic server paths now set
http2_keepalive_interval(30s),http2_keepalive_timeout(10s), andtcp_keepalive(60s) so idle connections are cleaned up and broken connections are detected promptly.what was tested
cargo check --workspacepasses cleanlyKeyspaceStatszero-initialization and aggregation at all call sites