Phase 0: finish service discovery guardrails#325
Merged
Conversation
…ode-visibility # Conflicts: # src/api/routes/status_metrics.zig # src/api/routes/status_metrics/metrics_routes.zig # src/api/routes/status_metrics/status_routes.zig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
env YOQ_SKIP_SLOW_TESTS=1 ZIG_GLOBAL_CACHE_DIR=.zig-global-cache ZIG_LOCAL_CACHE_DIR=.zig-local-cache timeout 30 zig build test -- --test-filter "route handles /v1/status?mode=service_rollout GET|handleMetricsPrometheus exposes service rollout metrics"timed out after 30s with no emitted failuresenv YOQ_SKIP_SLOW_TESTS=1 ZIG_GLOBAL_CACHE_DIR=.zig-global-cache ZIG_LOCAL_CACHE_DIR=.zig-local-cache timeout 30 zig build test -- --test-filter "userspace dns still resolves when dns interceptor is unavailable|userspace dns still resolves when load balancer add overflows"timed out after 30s with no emitted failuresScope note
The remaining restart, node-loss, and full rebuild verification from the plan depends on the canonical registry and reconciler work in later phases. This PR closes the Phase 0 guardrail and observability groundwork so that those later phases have one visible, fault-injectable shadow path to build on.