Phase 2: make the service reconciler authoritative#330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service_reconcilerthe authoritative writer for legacy DNS/BPF state and theservice_namescompatibility mirror whenservice_registry_reconcileris enableddns.unregisterServiceEndpointandstore.removeServiceNamesByNamehelpers so reconciliation works per service instead of relying on container-global deletesCommit
b94f640Make service reconciler authoritative for legacy DNSVerification
env YOQ_SKIP_SLOW_TESTS=1 ZIG_GLOBAL_CACHE_DIR=.zig-global-cache ZIG_LOCAL_CACHE_DIR=.zig-local-cache timeout 30 zig build test -- --test-filter "authoritative bootstrap populates DNS and compatibility mirror|authoritative reconciler owns legacy DNS writes when enabled|container bridge preserves legacy DNS and shadow events|lookupClusterService resolves from service_names table|registerServiceName and lookupServiceNames round-trip|unregisterServiceName removes service binding"timed out after 30s with no emitted failuresFollow-up