Merged
Conversation
add retry_on_5xx, circuit_breaker_threshold, and circuit_breaker_timeout_ms as configurable per-route fields through the full pipeline: manifest spec, TOML parser with validation, database schema, store layer, service registry, and proxy runtime route materialization
pass retry_on_5xx through RequestPolicy and per-route circuit breaker policy through recordEndpointFailure, endpointAllowsRequestLocked, and resolveUpstreamWithPolicy in both HTTP/1 and HTTP/2 proxy paths
add retry_on_5xx, circuit_breaker_threshold, and circuit_breaker_timeout_ms to service-level, per-route, and proxy status JSON output
add tests for retry_on_5xx policy enforcement, custom circuit breaker threshold trip behavior, and transport error retry independence from retry_on_5xx setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retry_on_5xx,circuit_breaker_threshold, andcircuit_breaker_timeout_msas configurable per-route fields through the full pipeline (manifest, db, registry, proxy runtime)default_circuit_policyconstantDesign notes
different routes sharing endpoints may have different circuit breaker thresholds — the calling route's policy governs the trip/half-open decision. all defaults match current hardcoded values so existing manifests behave identically.