Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u6shift variable wraps at 63, defeating the overflow guard — useu8with explicit@intCastfor the shift operandcommit_indexandlast_applied— use@maxto preserve monotonicitycommit_indexbefore the commit action is successfully queued — swap order so index only advances on success@intCasttou8— add length bounds checkspadded_len > payload.len— add bounds validation before subtractionBadRequesterror insteadbecome_followeraction fails to queue — return false on failure@bitCastof signedf_bsizetou64in disk space check — use validated@intCastsetsockoptfailures when setting socket timeouts — log warnings13 commits, 12 bug fixes + fmt.