fix: add accept timeout to test upstream server to prevent mirror test hang#381
Merged
fix: add accept timeout to test upstream server to prevent mirror test hang#381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mirror shadow traffic test (test 567) hangs indefinitely when the detached mirror thread fails to connect to the mirror upstream. The test's
TestUpstreamServer.acceptOne()blocks forever onposix.accept()with no timeout.Set a 5-second
SO_RCVTIMEOon the listening socket before spawning the accept thread soaccept()returnsEAGAINinstead of blocking forever if the mirror connection never arrives.