Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands contract and simulation coverage around two reliability-sensitive areas:
What Changed
204last_appliedin the on-disk database so replay after restart continues from the correct indexcommit_indexandlast_appliedWhy
Two restart-path gaps showed up while expanding the tests:
last_applied, which could stall or mis-sequence future applycommit_indexto0, which left a restarted follower willing to roll its state back via an older snapshotThe added tests reproduce those cases and the fixes make restart behavior line up with the persisted snapshot boundary.
Validation
YOQ_SKIP_SLOW_TESTS=1 zig build test-contract -Doptimize=ReleaseSafe -Dtest-filter='contract: s3'YOQ_SKIP_SLOW_TESTS=1 zig build test-sim -Doptimize=ReleaseSafe -Dtest-filter='sim:'YOQ_SKIP_SLOW_TESTS=1 zig build test -Doptimize=ReleaseSafe -Dtest-filter='restart preserves'YOQ_SKIP_SLOW_TESTS=1 zig build test -Doptimize=ReleaseSafe -Dtest-filter='init reloads snapshot boundary into commit_index and last_applied'YOQ_SKIP_SLOW_TESTS=1 zig build test -Doptimize=ReleaseSafe -Dtest-filter='install_snapshot restart ignores stale snapshot older than recovered boundary'YOQ_SKIP_SLOW_TESTS=1 zig build test-sim -Doptimize=ReleaseSafe -Dtest-filter='restarted leader reloads snapshot metadata and catches up lagging follower'