test the 3 run command modes- local,ssh and docker#12
test the 3 run command modes- local,ssh and docker#12aravindavk merged 4 commits intokadalu-tech:mainfrom
Conversation
Signed-off-by: Divyashree Jayaram <divyashreej15@gmail.com>
divyashreej
force-pushed
the
test-ssh-commands
branch
from
a8db380 to
947f8af
Compare
Signed-off-by: Divyashree Jayaram <divyashreej15@gmail.com>
|
verified output for run command in ssh mode: Summary:OK [418.08ms] total=1 passed=1 failed=0 verified output for run command in docker mode: |
|
@aravindavk could you please assign this PR to me, Assignee option is disabled for me. |
aravindavk
left a comment
aravindavk
left a comment
There was a problem hiding this comment.
Looks good. A few minor comments
binnacle/__init__.py
Outdated
| from binnacle.plugins.compare import compare_equal, compare_not_equal | ||
| from binnacle.core import debug, show_summary | ||
| from binnacle.plugins.http import http_get, http_post, http_put, http_delete, validated_json, http_base_url, http_set_header | ||
| from binnacle.plugins.commands import command_run,command_mode, command_node,command_ssh_user,command_ssh_sudo,command_ssh_pem_file,command_port,command_container |
There was a problem hiding this comment.
Please format this as
from binnacle.plugins.commands import (
command_run, command_mode, command_node,
command_ssh_user, command_ssh_sudo, command_ssh_pem_file,
command_port, command_container
)
binnacle/plugins/commands.py
Outdated
|
|
||
|
|
||
| def escaped_ssh_cmd(cmd): | ||
|
|
binnacle/plugins/commands.py
Outdated
|
|
||
|
|
||
| def full_cmd(cmd): | ||
|
|
| -i {_command_config.ssh_pem_file} -p {_command_config.ssh_port} \ | ||
| '{escaped_ssh_cmd(cmd)}' | ||
| """ | ||
|
|
|
@aravindavk Thank you, sure I will do it. |
2 participants
fixes #3 and #4