Skip to content

Conversation

@Mgrdich
Copy link
Contributor

@Mgrdich Mgrdich commented Apr 16, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
replaced all used lodash functions + added unit tests for the remaining stuff

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Mgrdich Mgrdich requested a review from a team as a code owner April 16, 2024 13:15
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress labels Apr 16, 2024
@Mgrdich Mgrdich linked an issue Apr 16, 2024 that may be closed by this pull request
2 tasks
@kapybro kapybro bot added status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Apr 16, 2024
@Mgrdich Mgrdich self-assigned this Apr 16, 2024
@Mgrdich Mgrdich added scope/frontend Related to frontend changes and removed status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed labels Apr 16, 2024
@Mgrdich Mgrdich requested a review from Haarolean April 16, 2024 13:16
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Haarolean Haarolean added type/chore Boring stuff, could be refactoring or tech debt status/triage/completed Automatic triage completed labels Apr 16, 2024
@Haarolean Haarolean changed the title Chore/deprecate lodash FE: Remove lodash lib Apr 16, 2024
@Haarolean Haarolean merged commit 94f9ce6 into main Apr 17, 2024
@Haarolean Haarolean deleted the chore/deprecate-lodash branch April 17, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FE: Remove lodash library

3 participants