Validate ssl options, relax use_ssl false condns #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@comogo If you have a few minutes, would you take a look at this and let me know if I've done anything incorrect / bad with respect to the ssl options? Thanks! |
Meant to do this before but forgot
Collaborator
Author
|
@comogo I'm going to merge this because I need it to move forward on something else, but I'd still appreciate any feedback you have. |
Member
|
This change will prevent configuring SSL on a per worker basis |
Member
|
Sorry I noticed that late |
Collaborator
Author
|
@bjhaid How's that? The mechanism is still the same, it just goes through a validation function first. |
Collaborator
Author
|
Oh nevermind, I see it now. OK, I will fix that ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178
I'm not an ssl expert so wasn't sure what else to do for validation. This checks for
:certfile:cacertfileand:keyfilebeing set and pointing to readable files. If anyone has input on that it'd be appreciated!