-
Notifications
You must be signed in to change notification settings - Fork 164
Update credo, dialyzir, excoveralls, add .credo.exs #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| # This file contains the configuration for Credo and you are probably reading | ||
| # this after creating it with `mix credo.gen.config`. | ||
| # | ||
| # If you find anything wrong or unclear in this file, please report an | ||
| # issue on GitHub: https://github.com/rrrene/credo/issues | ||
| # | ||
| %{ | ||
| # | ||
| # You can have as many configs as you like in the `configs:` field. | ||
| configs: [ | ||
| %{ | ||
| # | ||
| # Run any exec using `mix credo -C <name>`. If no exec name is given | ||
| # "default" is used. | ||
| # | ||
| name: "default", | ||
| # | ||
| # These are the files included in the analysis: | ||
| files: %{ | ||
| # | ||
| # You can give explicit globs or simply directories. | ||
| # In the latter case `**/*.{ex,exs}` will be used. | ||
| # | ||
| included: ["lib/", "src/", "web/", "apps/"], | ||
| excluded: [~r"/_build/", ~r"/deps/"] | ||
| }, | ||
| # | ||
| # If you create your own checks, you must specify the source files for | ||
| # them here, so they can be loaded by Credo before running the analysis. | ||
| # | ||
| requires: [], | ||
| # | ||
| # Credo automatically checks for updates, like e.g. Hex does. | ||
| # You can disable this behaviour below: | ||
| # | ||
| check_for_updates: true, | ||
| # | ||
| # If you want to enforce a style guide and need a more traditional linting | ||
| # experience, you can change `strict` to `true` below: | ||
| # | ||
| strict: false, | ||
| # | ||
| # If you want to use uncolored output by default, you can change `color` | ||
| # to `false` below: | ||
| # | ||
| color: true, | ||
| # | ||
| # You can customize the parameters of any check by adding a second element | ||
| # to the tuple. | ||
| # | ||
| # To disable a check put `false` as second element: | ||
| # | ||
| # {Credo.Check.Design.DuplicatedCode, false} | ||
| # | ||
| checks: [ | ||
| {Credo.Check.Consistency.ExceptionNames}, | ||
| {Credo.Check.Consistency.LineEndings}, | ||
| {Credo.Check.Consistency.ParameterPatternMatching}, | ||
| {Credo.Check.Consistency.SpaceAroundOperators}, | ||
| {Credo.Check.Consistency.SpaceInParentheses}, | ||
| {Credo.Check.Consistency.TabsOrSpaces}, | ||
|
|
||
| # For some checks, like AliasUsage, you can only customize the priority | ||
| # Priority values are: `low, normal, high, higher` | ||
| # | ||
| {Credo.Check.Design.AliasUsage, priority: :low}, | ||
|
|
||
| # For others you can set parameters | ||
|
|
||
| # If you don't want the `setup` and `test` macro calls in ExUnit tests | ||
| # or the `schema` macro in Ecto schemas to trigger DuplicatedCode, just | ||
| # set the `excluded_macros` parameter to `[:schema, :setup, :test]`. | ||
| # | ||
| {Credo.Check.Design.DuplicatedCode, excluded_macros: []}, | ||
|
|
||
| # You can also customize the exit_status of each check. | ||
| # If you don't want TODO comments to cause `mix credo` to fail, just | ||
| # set this value to 0 (zero). | ||
| # | ||
| {Credo.Check.Design.TagTODO, exit_status: 2}, | ||
| {Credo.Check.Design.TagFIXME}, | ||
|
|
||
| {Credo.Check.Readability.FunctionNames}, | ||
| {Credo.Check.Readability.LargeNumbers}, | ||
| {Credo.Check.Readability.MaxLineLength, priority: :low, max_length: 80}, | ||
| {Credo.Check.Readability.ModuleAttributeNames}, | ||
| {Credo.Check.Readability.ModuleDoc}, | ||
| {Credo.Check.Readability.ModuleNames}, | ||
| {Credo.Check.Readability.ParenthesesOnZeroArityDefs}, | ||
| {Credo.Check.Readability.ParenthesesInCondition}, | ||
| {Credo.Check.Readability.PredicateFunctionNames}, | ||
| {Credo.Check.Readability.PreferImplicitTry}, | ||
| {Credo.Check.Readability.RedundantBlankLines}, | ||
| {Credo.Check.Readability.StringSigils}, | ||
| {Credo.Check.Readability.TrailingBlankLine}, | ||
| {Credo.Check.Readability.TrailingWhiteSpace}, | ||
| {Credo.Check.Readability.VariableNames}, | ||
| {Credo.Check.Readability.Semicolons}, | ||
| {Credo.Check.Readability.SpaceAfterCommas}, | ||
|
|
||
| {Credo.Check.Refactor.DoubleBooleanNegation}, | ||
| {Credo.Check.Refactor.CondStatements}, | ||
| {Credo.Check.Refactor.CyclomaticComplexity}, | ||
| {Credo.Check.Refactor.FunctionArity}, | ||
| {Credo.Check.Refactor.LongQuoteBlocks}, | ||
| {Credo.Check.Refactor.MatchInCondition}, | ||
| {Credo.Check.Refactor.NegatedConditionsInUnless}, | ||
| {Credo.Check.Refactor.NegatedConditionsWithElse}, | ||
| {Credo.Check.Refactor.Nesting}, | ||
| {Credo.Check.Refactor.PipeChainStart}, | ||
| {Credo.Check.Refactor.UnlessWithElse}, | ||
|
|
||
| {Credo.Check.Warning.BoolOperationOnSameValues}, | ||
| {Credo.Check.Warning.IExPry}, | ||
| {Credo.Check.Warning.IoInspect}, | ||
| {Credo.Check.Warning.LazyLogging}, | ||
| {Credo.Check.Warning.OperationOnSameValues}, | ||
| {Credo.Check.Warning.OperationWithConstantResult}, | ||
| {Credo.Check.Warning.UnusedEnumOperation}, | ||
| {Credo.Check.Warning.UnusedFileOperation}, | ||
| {Credo.Check.Warning.UnusedKeywordOperation}, | ||
| {Credo.Check.Warning.UnusedListOperation}, | ||
| {Credo.Check.Warning.UnusedPathOperation}, | ||
| {Credo.Check.Warning.UnusedRegexOperation}, | ||
| {Credo.Check.Warning.UnusedStringOperation}, | ||
| {Credo.Check.Warning.UnusedTupleOperation}, | ||
| {Credo.Check.Warning.RaiseInsideRescue}, | ||
|
|
||
| # Controversial and experimental checks (opt-in, just remove `, false`) | ||
| # | ||
| {Credo.Check.Refactor.ABCSize, false}, | ||
| {Credo.Check.Refactor.AppendSingleItem, false}, | ||
| {Credo.Check.Refactor.VariableRebinding, false}, | ||
| {Credo.Check.Warning.MapGetUnsafePass, false}, | ||
| {Credo.Check.Consistency.MultiAliasImportRequireUse, false}, | ||
|
|
||
| # Deprecated checks (these will be deleted after a grace period) | ||
| # | ||
| {Credo.Check.Readability.Specs, false}, | ||
| {Credo.Check.Warning.NameRedeclarationByAssignment, false}, | ||
| {Credo.Check.Warning.NameRedeclarationByCase, false}, | ||
| {Credo.Check.Warning.NameRedeclarationByDef, false}, | ||
| {Credo.Check.Warning.NameRedeclarationByFn, false}, | ||
|
|
||
| # Custom checks can be created using `mix credo.gen.check`. | ||
| # | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,19 @@ | ||
| %{"bunt": {:hex, :bunt, "0.1.6", "5d95a6882f73f3b9969fdfd1953798046664e6f77ec4e486e6fafc7caad97c6f", [:mix], [], "hexpm"}, | ||
| "certifi": {:hex, :certifi, "0.7.0", "861a57f3808f7eb0c2d1802afeaae0fa5de813b0df0979153cbafcd853ababaf", [:rebar3], [], "hexpm"}, | ||
| "credo": {:hex, :credo, "0.5.3", "0c405b36e7651245a8ed63c09e2d52c2e2b89b6d02b1570c4d611e0fcbecf4a2", [:mix], [{:bunt, "~> 0.1.6", [hex: :bunt, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "dialyxir": {:hex, :dialyxir, "0.4.3", "a4daeebd0107de10d3bbae2ccb6b8905e69544db1ed5fe9148ad27cd4cb2c0cd", [:mix], [], "hexpm"}, | ||
| %{"bunt": {:hex, :bunt, "0.2.0", "951c6e801e8b1d2cbe58ebbd3e616a869061ddadcc4863d0a2182541acae9a38", [:mix], [], "hexpm"}, | ||
| "certifi": {:hex, :certifi, "1.2.1", "c3904f192bd5284e5b13f20db3ceac9626e14eeacfbb492e19583cf0e37b22be", [:rebar3], [], "hexpm"}, | ||
| "credo": {:hex, :credo, "0.8.4", "4e50acac058cf6292d6066e5b0d03da5e1483702e1ccde39abba385c9f03ead4", [:mix], [{:bunt, "~> 0.2.0", [hex: :bunt, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "dialyxir": {:hex, :dialyxir, "0.5.0", "5bc543f9c28ecd51b99cc1a685a3c2a1a93216990347f259406a910cf048d1d7", [:mix], [], "hexpm"}, | ||
| "dialyze": {:hex, :dialyze, "0.2.1", "9fb71767f96649020d769db7cbd7290059daff23707d6e851e206b1fdfa92f9d", [:mix], []}, | ||
| "earmark": {:hex, :earmark, "1.0.3", "89bdbaf2aca8bbb5c97d8b3b55c5dd0cff517ecc78d417e87f1d0982e514557b", [:mix], [], "hexpm"}, | ||
| "ex_doc": {:hex, :ex_doc, "0.14.5", "c0433c8117e948404d93ca69411dd575ec6be39b47802e81ca8d91017a0cf83c", [:mix], [{:earmark, "~> 1.0", [hex: :earmark, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "excoveralls": {:hex, :excoveralls, "0.6.0", "bd8565173ad1b97c29329dcbabb9effb56a5fcd1a698fd2097108dfe84b4c4ef", [:mix], [{:exjsx, "~> 3.0", [hex: :exjsx, repo: "hexpm", optional: false]}, {:hackney, ">= 0.12.0", [hex: :hackney, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "exjsx": {:hex, :exjsx, "3.2.1", "1bc5bf1e4fd249104178f0885030bcd75a4526f4d2a1e976f4b428d347614f0f", [:mix], [{:jsx, "~> 2.8.0", [hex: :jsx, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "excoveralls": {:hex, :excoveralls, "0.7.1", "3dd659db19c290692b5e2c4a2365ae6d4488091a1ba58f62dcbdaa0c03da5491", [:mix], [{:exjsx, ">= 3.0.0", [hex: :exjsx, repo: "hexpm", optional: false]}, {:hackney, ">= 0.12.0", [hex: :hackney, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "exjsx": {:hex, :exjsx, "4.0.0", "60548841e0212df401e38e63c0078ec57b33e7ea49b032c796ccad8cde794b5c", [:mix], [{:jsx, "~> 2.8.0", [hex: :jsx, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "fs": {:hex, :fs, "0.9.2"}, | ||
| "hackney": {:hex, :hackney, "1.6.5", "8c025ee397ac94a184b0743c73b33b96465e85f90a02e210e86df6cbafaa5065", [:rebar3], [{:certifi, "0.7.0", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "1.2.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "1.0.1", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "1.0.2", [hex: :mimerl, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "1.1.1", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "idna": {:hex, :idna, "1.2.0", "ac62ee99da068f43c50dc69acf700e03a62a348360126260e87f2b54eced86b2", [:rebar3], [], "hexpm"}, | ||
| "jsx": {:hex, :jsx, "2.8.1", "1453b4eb3615acb3e2cd0a105d27e6761e2ed2e501ac0b390f5bbec497669846", [:mix, :rebar3], [], "hexpm"}, | ||
| "hackney": {:hex, :hackney, "1.8.6", "21a725db3569b3fb11a6af17d5c5f654052ce9624219f1317e8639183de4a423", [:rebar3], [{:certifi, "1.2.1", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "5.0.2", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "1.0.1", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "1.0.2", [hex: :mimerl, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "1.1.1", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "idna": {:hex, :idna, "5.0.2", "ac203208ada855d95dc591a764b6e87259cb0e2a364218f215ad662daa8cd6b4", [:rebar3], [{:unicode_util_compat, "0.2.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm"}, | ||
| "jsx": {:hex, :jsx, "2.8.2", "7acc7d785b5abe8a6e9adbde926a24e481f29956dd8b4df49e3e4e7bcc92a018", [:mix, :rebar3], [], "hexpm"}, | ||
| "metrics": {:hex, :metrics, "1.0.1", "25f094dea2cda98213cecc3aeff09e940299d950904393b2a29d191c346a8486", [:rebar3], [], "hexpm"}, | ||
| "mimerl": {:hex, :mimerl, "1.0.2", "993f9b0e084083405ed8252b99460c4f0563e41729ab42d9074fd5e52439be88", [:rebar3], [], "hexpm"}, | ||
| "mix_test_watch": {:hex, :mix_test_watch, "0.2.6"}, | ||
| "snappy": {:git, "https://github.com/fdmanana/snappy-erlang-nif", "c4cd1bb35f3a3a399737d64bd03b479817b90e75", []}, | ||
| "ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.1", "28a4d65b7f59893bc2c7de786dec1e1555bd742d336043fe644ae956c3497fbe", [:make, :rebar], [], "hexpm"}} | ||
| "ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.1", "28a4d65b7f59893bc2c7de786dec1e1555bd742d336043fe644ae956c3497fbe", [:make, :rebar], [], "hexpm"}, | ||
| "unicode_util_compat": {:hex, :unicode_util_compat, "0.2.0", "dbbccf6781821b1c0701845eaf966c9b6d83d7c3bfc65ca2b78b88b8678bfa35", [:rebar3], [], "hexpm"}} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 @ebert[bot]