Fix gzip test wrt changing versions of libz #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #253 for discussion. There are changes to produce.ex here but they are only formatting and refactoring that made it easier to reason about this problem.
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| def create_request( | ||
| correlation_id, | ||
| client_id, | ||
| request = %Request{compression: compression, messages: messages} |
There was a problem hiding this comment.
File has the variable name before the pattern while most of the files have the variable name after the pattern when naming parameter pattern matches
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/kafkaex/kafka_ex/pulls/256. |
| message_set | ||
| ) do | ||
| KafkaEx.Protocol.create_request(:produce, correlation_id, client_id) <> | ||
| << required_acks :: 16-signed, timeout :: 32-signed, 1 :: 32-signed >> <> |
joshuawscott
approved these changes
Nov 29, 2017
Member
joshuawscott
left a comment
joshuawscott
left a comment
There was a problem hiding this comment.
Seems ok to me, a little ugly, but not sure what else we'd do.
robotarmy
pushed a commit
to RAM9/kafka_ex
that referenced
this pull request
Apr 7, 2025
Fix gzip test wrt changing versions of libz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #253 for discussion. There are changes to produce.ex here but they
are only formatting and refactoring that made it easier to reason about
this problem.