Skip to content

Adds a clause to match when a partial messageSet is received. #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2018
Merged

Adds a clause to match when a partial messageSet is received. #268

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52f16d6
Adds a clause to match when a partial messageSet is received.
eloraburns Dec 27, 2017
cbbcde0
Uses a guard to match a message larger than the bytes fetched.
eloraburns Dec 29, 2017
1f96b22
Fix some typos
eloraburns Jan 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/kafka_ex/protocol/fetch.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ defmodule KafkaEx.Protocol.Fetch do
defp parse_message_set([last|_] = list, _) do
{:ok, Enum.reverse(list), last.offset}
end
defp parse_message_set(_, << offset :: 64, msg_size :: 32, partial_message_data :: binary >>) when byte_size(partial_message_data) < msg_size do
raise RuntimeError, "Insufficient data fetched at offset #{offset}. Message size is #{msg_size} but only received #{byte_size(partial_message_data)} bytes. Try increasing max_bytes."
end

# handles the single message case and the batch (compression) case
defp append_messages([], list) do
Expand Down