Remove compile warnings #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
|
|
||
| defp remove_stale_brokers(brokers, metadata_brokers) do | ||
| {brokers_to_keep, brokers_to_remove} = Enum.partition(brokers, fn(broker) -> | ||
| {brokers_to_keep, brokers_to_remove} = apply(Enum, :partition, [brokers, fn(broker) -> |
There was a problem hiding this comment.
Line is too long (max is 80, was 94).
| case Regex.scan(~r/^(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})$/, host) do | ||
| [match_data] = [[_, _, _, _, _]] -> match_data |> tl |> List.flatten |> Enum.map(&String.to_integer/1) |> List.to_tuple | ||
| _ -> to_char_list(host) | ||
| _ -> apply(String, :to_char_list, [host]) # to_char_list is deprecated from Elixir 1.3 onward |
There was a problem hiding this comment.
Line is too long (max is 80, was 99).
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/kafkaex/kafka_ex/pulls/274. |
bjhaid
approved these changes
Mar 2, 2018
Member
bjhaid
left a comment
bjhaid
left a comment
There was a problem hiding this comment.
LGTM, we need to come up with some policy for deprecating older versions of Elixir
| def terminate(_, state) do | ||
| Logger.log(:debug, "Shutting down worker #{inspect state.worker_name}") | ||
| if state.event_pid do | ||
| GenEvent.stop(state.event_pid) |
Member
There was a problem hiding this comment.
This is probably dead code, there should be no use of GenEvent in Kafkaex AFAIK
Member
|
Thanks again @thecodeboss |
robotarmy
pushed a commit
to RAM9/kafka_ex
that referenced
this pull request
Apr 7, 2025
Remove compile warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling kafka_ex, there are a bunch of annoying compile warnings that get spit out on later Elixir versions like 1.5 and 1.6.
Firstly,
char_listhas been deprecated in favour ofcharlistin many places. For typespecs, we can support both by using[char]instead. ForString.to_char_list, we can useapply(String, :to_char_list, [arg])to stop the warning, and the method exists in all Elixir versions.Second,
Enum.partitionis deprecated, so I tweaked to remove the warning.I also removed some unused arguments, a missing protocol implementation for
Enumerable.slice/1, and a typo.