Skip to content

Set sane default values for using the default worker #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Set sane default values for using the default worker #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8472c5b
Enable default worker by default
efcasado Apr 2, 2018
3aaa0bb
Set "kafka_ex" as the default consumer group
efcasado Apr 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/kafka_ex.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ defmodule KafkaEx do
def build_worker_options(worker_init) do
defaults = [
uris: Application.get_env(:kafka_ex, :brokers),
consumer_group: Application.get_env(:kafka_ex, :consumer_group),
consumer_group: Config.consumer_group(),
use_ssl: Config.use_ssl(),
ssl_options: Config.ssl_options(),
]
Expand Down Expand Up @@ -533,7 +533,7 @@ defmodule KafkaEx do
max_seconds = Application.get_env(:kafka_ex, :max_seconds, 60)
{:ok, pid} = KafkaEx.Supervisor.start_link(Config.server_impl, max_restarts, max_seconds)

if Application.get_env(:kafka_ex, :disable_default_worker) == true do
if Config.disable_default_worker do
{:ok, pid}
else
case KafkaEx.create_worker(Config.default_worker, []) do
Expand Down
10 changes: 10 additions & 0 deletions lib/kafka_ex/config.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ defmodule KafkaEx.Config do

require Logger

@doc false
def disable_default_worker do
Application.get_env(:kafka_ex, :disable_default_worker, false)
end

@doc false
def consumer_group do
Application.get_env(:kafka_ex, :consumer_group, "kafka_ex")
end

@doc false
def use_ssl, do: Application.get_env(:kafka_ex, :use_ssl, false)

Expand Down