fix some details in KafkaEx.GenConsumer.Manager #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes most of the state-altering private functions in Manager to
return `{:ok, state}` so that we can catch and report errors a little
more easily when they happen
robotarmy
pushed a commit
to RAM9/kafka_ex
that referenced
this pull request
Apr 7, 2025
fix some details in KafkaEx.GenConsumer.Manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the state-returning private functions to return {:ok, state}. This will allow us to catch and handle errors better moving forward, and also makes it a little easier to keep track of what the private functions are doing.