Iolist cleanup #290
Merged
Iolist cleanup #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/kafkaex/kafka_ex/pulls/290. |
bjhaid
approved these changes
May 23, 2018
Member
Author
|
Created #291 to track making this happen to the other protocol messages. |
habutre
added a commit
to habutre/kafka_ex
that referenced
this pull request
Oct 29, 2019
This commit aim to review possible uses of binary concatenation rather than iolist concat that according with outcomes from issues kafkaex#231 and kafkaex#290 had proofed to be more efficient In the end any other binary concat were found, but some small changes will be proposed as follows: 1. The Common module was returning a empty string instead empty iolist on `topic_data([])`, there is not big improvements here but a normalization among protocol modules 2. Replace literal size values to meaningful module attributes
habutre
added a commit
to habutre/kafka_ex
that referenced
this pull request
Oct 29, 2019
This commit aim to review possible uses of binary concatenation rather than iolist concat that according with outcomes from issues kafkaex#231 and kafkaex#290 had proofed to be more efficient In the end any other binary concat were found, but some small changes will be proposed as follows: 1. The Common module was returning a empty string instead empty iolist on `topic_data([])`, there is not big improvements here but a normalization among protocol modules 2. Replace literal integer size values to meaningful module attributes on Produce module
robotarmy
pushed a commit
to RAM9/kafka_ex
that referenced
this pull request
Apr 7, 2025
Iolist cleanup
robotarmy
pushed a commit
to RAM9/kafka_ex
that referenced
this pull request
Apr 7, 2025
This commit aim to review possible uses of binary concatenation rather than iolist concat that according with outcomes from issues kafkaex#231 and kafkaex#290 had proofed to be more efficient In the end any other binary concat were found, but some small changes will be proposed as follows: 1. The Common module was returning a empty string instead empty iolist on `topic_data([])`, there is not big improvements here but a normalization among protocol modules 2. Replace literal integer size values to meaningful module attributes on Produce module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #231 by @vjache
This just handles the merge conflicts and I will also clean up ebert complaints
Original description:
This change makes using iolist instead of contiguous binary when building packet being compressed and/or sent.
P.S. Unit tests & dialyzer passed successfully but I'm failed to wait for finish integration tests, they just hanging without any log messages. Anyway, I making this PR, in case someone find time to run all integration tests.