revert: Gate Agent CR templates behind enabled flags (#1197) #1226
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 81a98d4. Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
onematchfox
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts changes from #1197 that incorrectly configured Helm chart dependency conditions. The revert restores the proper condition paths that align with the chart's values.yaml structure where agents are nested under the agents: key.
Changes:
- Updated Helm chart dependency conditions to use
agents.<agent-name>.enabledinstead of<agent-name>.enabled - Ensures consistency with the values.yaml structure and existing patterns in the chart
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EItanya
approved these changes
Jan 21, 2026
Contributor
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
This is completely my fault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #1197 which purported to fix #1169 (which I cannot reproduce). Installing with values like the following correctly excludes any agents that are not enabled.
Fixes #1225.