Conversation
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the GET /thread_dump debugging endpoint in the kagent-adk FastAPI app so it no longer returns 500 due to faulthandler.dump_traceback() requiring a real OS file descriptor.
Changes:
- Replace
io.StringIO()withtempfile.TemporaryFile(mode="w+")forfaulthandler.dump_traceback()output. - Enable
all_threads=Trueto capture stack traces for all threads.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
Signed-off-by: Jeremy Alvis <jeremy.alvis@solo.io>
EItanya
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/thread_dumpendpoint which returns500 Internal Server Errorbecausefaulthandler.dump_traceback()requires a real OS file descriptor, but the code passesio.StringIO()which doesn't have onetempfile.TemporaryFile(mode="w+")instead, and addall_threads=Trueto capture all thread stacksFixes #1426
Testing
Deployed to Kind cluster, confirmed
curl http://localhost:8080/thread_dumpreturns thread stacks instead of 500