feat: bump kagent-tools v0.1.0#1449
Conversation
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
There was a problem hiding this comment.
Pull request overview
Updates the repo to use kagent-tools v0.1.0 and refreshes related Go dependencies, wiring Helm chart dependency versions through Makefile-driven templating.
Changes:
- Parameterized the
kagent-toolsHelm dependency version inChart-template.yamlviaKAGENT_TOOLS_VERSION. - Added
KAGENT_TOOLS_VERSIONextraction fromgo/go.modand passed it intoenvsubstinmake helm-version. - Bumped multiple Go module dependencies, including adding
github.com/kagent-dev/tools v0.1.0(indirect).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| helm/kagent/Chart-template.yaml | Uses a templated variable for the kagent-tools chart dependency version. |
| go/go.mod | Updates dependency set to include github.com/kagent-dev/tools v0.1.0 and other bumps. |
| Makefile | Derives and injects KAGENT_TOOLS_VERSION into Helm chart generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Makefile
Outdated
| KMCP_VERSION ?= $(shell $(AWK) '/github\.com\/kagent-dev\/kmcp/ { print substr($$2, 2) }' go/go.mod) | ||
| KAGENT_TOOLS_VERSION ?= $(shell $(AWK) '/github\.com\/kagent-dev\/tools/ { print substr($$2, 2) }' go/go.mod) |
There was a problem hiding this comment.
Deriving the Helm chart version by grepping go/go.mod is brittle: go mod tidy can drop or change indirect require lines, and the regex can also match replace/other contexts, returning an unexpected token for $$2. Consider sourcing chart versions from a dedicated versions file/variable (e.g., KAGENT_TOOLS_CHART_VERSION), or using a more structured query (like go list -m for the module) plus a stricter match to require lines only.
| KMCP_VERSION ?= $(shell $(AWK) '/github\.com\/kagent-dev\/kmcp/ { print substr($$2, 2) }' go/go.mod) | |
| KAGENT_TOOLS_VERSION ?= $(shell $(AWK) '/github\.com\/kagent-dev\/tools/ { print substr($$2, 2) }' go/go.mod) | |
| KMCP_VERSION ?= $(shell cd go && go list -m -f '{{.Version}}' github.com/kagent-dev/kmcp 2>/dev/null | sed 's/^v//') | |
| KAGENT_TOOLS_VERSION ?= $(shell cd go && go list -m -f '{{.Version}}' github.com/kagent-dev/tools 2>/dev/null | sed 's/^v//') |
helm/kagent/Chart-template.yaml
Outdated
| condition: kmcp.enabled | ||
| - name: kagent-tools | ||
| version: 0.0.13 | ||
| version: ${KAGENT_TOOLS_VERSION} |
There was a problem hiding this comment.
This couples the Helm dependency chart version to whatever KAGENT_TOOLS_VERSION is set to during templating. If KAGENT_TOOLS_VERSION is sourced from the Go module version, that assumes the Helm chart versioning always matches the Go module version, which may not be true and can lead to pulling a non-existent chart version. Consider using a chart-specific variable name/value source (e.g., KAGENT_TOOLS_CHART_VERSION) to avoid conflating artifact versions.
| version: ${KAGENT_TOOLS_VERSION} | |
| version: ${KAGENT_TOOLS_CHART_VERSION} |
No description provided.