Skip to content

feat: bump kagent-tools v0.1.0#1449

Merged
EItanya merged 4 commits intorelease/v0.7.xfrom
eitanya/bump-tools-07x
Mar 6, 2026
Merged

feat: bump kagent-tools v0.1.0#1449
EItanya merged 4 commits intorelease/v0.7.xfrom
eitanya/bump-tools-07x

Conversation

@EItanya
Copy link
Contributor

@EItanya EItanya commented Mar 5, 2026

No description provided.

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Copilot AI review requested due to automatic review settings March 5, 2026 20:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo to use kagent-tools v0.1.0 and refreshes related Go dependencies, wiring Helm chart dependency versions through Makefile-driven templating.

Changes:

  • Parameterized the kagent-tools Helm dependency version in Chart-template.yaml via KAGENT_TOOLS_VERSION.
  • Added KAGENT_TOOLS_VERSION extraction from go/go.mod and passed it into envsubst in make helm-version.
  • Bumped multiple Go module dependencies, including adding github.com/kagent-dev/tools v0.1.0 (indirect).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
helm/kagent/Chart-template.yaml Uses a templated variable for the kagent-tools chart dependency version.
go/go.mod Updates dependency set to include github.com/kagent-dev/tools v0.1.0 and other bumps.
Makefile Derives and injects KAGENT_TOOLS_VERSION into Helm chart generation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Makefile Outdated
Comment on lines +107 to +108
KMCP_VERSION ?= $(shell $(AWK) '/github\.com\/kagent-dev\/kmcp/ { print substr($$2, 2) }' go/go.mod)
KAGENT_TOOLS_VERSION ?= $(shell $(AWK) '/github\.com\/kagent-dev\/tools/ { print substr($$2, 2) }' go/go.mod)
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deriving the Helm chart version by grepping go/go.mod is brittle: go mod tidy can drop or change indirect require lines, and the regex can also match replace/other contexts, returning an unexpected token for $$2. Consider sourcing chart versions from a dedicated versions file/variable (e.g., KAGENT_TOOLS_CHART_VERSION), or using a more structured query (like go list -m for the module) plus a stricter match to require lines only.

Suggested change
KMCP_VERSION ?= $(shell $(AWK) '/github\.com\/kagent-dev\/kmcp/ { print substr($$2, 2) }' go/go.mod)
KAGENT_TOOLS_VERSION ?= $(shell $(AWK) '/github\.com\/kagent-dev\/tools/ { print substr($$2, 2) }' go/go.mod)
KMCP_VERSION ?= $(shell cd go && go list -m -f '{{.Version}}' github.com/kagent-dev/kmcp 2>/dev/null | sed 's/^v//')
KAGENT_TOOLS_VERSION ?= $(shell cd go && go list -m -f '{{.Version}}' github.com/kagent-dev/tools 2>/dev/null | sed 's/^v//')

Copilot uses AI. Check for mistakes.
condition: kmcp.enabled
- name: kagent-tools
version: 0.0.13
version: ${KAGENT_TOOLS_VERSION}
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This couples the Helm dependency chart version to whatever KAGENT_TOOLS_VERSION is set to during templating. If KAGENT_TOOLS_VERSION is sourced from the Go module version, that assumes the Helm chart versioning always matches the Go module version, which may not be true and can lead to pulling a non-existent chart version. Consider using a chart-specific variable name/value source (e.g., KAGENT_TOOLS_CHART_VERSION) to avoid conflating artifact versions.

Suggested change
version: ${KAGENT_TOOLS_VERSION}
version: ${KAGENT_TOOLS_CHART_VERSION}

Copilot uses AI. Check for mistakes.
EItanya added 3 commits March 5, 2026 20:12
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
@EItanya EItanya merged commit b4c0066 into release/v0.7.x Mar 6, 2026
22 checks passed
@EItanya EItanya deleted the eitanya/bump-tools-07x branch March 6, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants