Skip to content

[DOCS] helm: fix documentation drift in README-testing.md#1688

Merged
EItanya merged 5 commits intokagent-dev:mainfrom
TOMOFUMI-KONDO:docs/helm-test-doc
Apr 30, 2026
Merged

[DOCS] helm: fix documentation drift in README-testing.md#1688
EItanya merged 5 commits intokagent-dev:mainfrom
TOMOFUMI-KONDO:docs/helm-test-doc

Conversation

@TOMOFUMI-KONDO
Copy link
Copy Markdown
Contributor

fixed some documentation drift in helm/README-testing.md

  • Test Structure, Test Coverage
    • Update test file names to match actual files, remove the description of non-existent files, add missing test entries
  • Example Test Scenarios
    • fix incorrect CLI flags of latest helm-unittest (v1.0.3)
      • Recent CI also runs with helm-unittest (v1.0.3)
      • Some options changed by version-up of helm-unittest

Copilot AI review requested due to automatic review settings April 17, 2026 15:31
@TOMOFUMI-KONDO TOMOFUMI-KONDO requested a review from yuval-k as a code owner April 17, 2026 15:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates helm/README-testing.md to match the current Helm chart unittest suite layout and to align CLI examples with helm-unittest v1.0.3.

Changes:

  • Updated the documented test directory structure and test file names to reflect the current helm/kagent/tests contents.
  • Revised the “Test Coverage” section to remove non-existent test categories and add missing ones.
  • Corrected the example helm-unittest CLI usage for providing a values file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread helm/README-testing.md Outdated
Update test file names to match actual files (e.g. deployment_test.yaml
→ controller-deployment_test.yaml), remove non-existent
integration_test.yaml, add missing test entries (postgresql,
security-context, toolserver, ui-deployment, ui-service), fix incorrect
CLI flags (--set → removed, -f → -v for values files), and correct
global.tag to tag.

Signed-off-by: TOMOFUMI-KONDO <ugax2kontomo0314@gmail.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread helm/README-testing.md
@TOMOFUMI-KONDO
Copy link
Copy Markdown
Contributor Author

@EItanya @ilackarms @yuval-k
Could you review this when you have time, please?

@TOMOFUMI-KONDO
Copy link
Copy Markdown
Contributor Author

@EItanya
It apperas that the workflows are not running because markdown files are ignored like below:

  pull_request:
    branches: [main, release/v0.7.x]
    paths-ignore:
      - "**/*.md"

Should I fix the workflow triggers not to ignore markdown files?

@EItanya EItanya merged commit ce59f67 into kagent-dev:main Apr 30, 2026
4 checks passed
@TOMOFUMI-KONDO TOMOFUMI-KONDO deleted the docs/helm-test-doc branch April 30, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants