fix: resolve main image scan failures#1742
Merged
EItanya merged 4 commits intokagent-dev:mainfrom Apr 25, 2026
Merged
Conversation
Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
jsonmp-k8
requested review from
EItanya,
ilackarms,
peterj and
yuval-k
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CI image vulnerability scanning for the Go ADK “full” image, patches the pinned sandbox-runtime install to address a vulnerable lodash-es lock, and updates Python ADK dependency floors/lockfiles.
Changes:
- Update
.github/workflows/image-scan.yamlmatrix to scan the correct image name/tag forgolang-adk-full(namegolang-adk, tag suffix-full). - Patch sandbox-runtime installation steps in
python/Dockerfileandgo/Dockerfile.fullto install a fixedlodash-esversion while keeping the pinned runtime revision. - Raise
google-adkminimum version constraints and refreshpython/uv.lock, plus update the Python ADK template pin.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python/uv.lock | Updates locked dependency set, including google-adk and related Google packages. |
| python/packages/kagent-adk/pyproject.toml | Raises google-adk floor to >=1.28.1,<2. |
| python/packages/agentsts-adk/pyproject.toml | Raises google-adk floor to >=1.28.1,<2. |
| python/Dockerfile | Adjusts sandbox-runtime install to force a non-vulnerable lodash-es version. |
| go/core/cli/internal/agent/frameworks/adk/python/templates/pyproject.toml.tmpl | Updates template pin for google-adk. |
| go/Dockerfile.full | Adjusts sandbox-runtime install to force a non-vulnerable lodash-es version. |
| .github/workflows/image-scan.yaml | Fixes scan target selection to match the image tag published by make build-golang-adk-full. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
jeffspahr
reviewed
Apr 24, 2026
Contributor
jeffspahr
left a comment
jeffspahr
left a comment
There was a problem hiding this comment.
I found one security hygiene issue in the sandbox-runtime patch: the replacement version currently pins a deprecated bad lodash-es release. 4.18.1 builds and audits clean in the same sandbox-runtime install flow.
lodash-es@4.18.0 is marked as deprecated by npm ("Bad release. Please
use lodash-es@4.17.23 instead."). Use 4.18.1 which is not deprecated
and passes npm audit with zero vulnerabilities.
Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
jsonmp-k8
requested review from
iplay88keys,
jmhbh and
supreme-gg-gg
as code owners
Contributor
Author
|
@EItanya This one too |
EItanya
approved these changes
Apr 25, 2026
Contributor
|
Thanks so much for tracking these down :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang-adk-fulljob scans the image name and tag thatmake build-golang-adk-fullactually publisheslodash-esversion without repinning the whole external runtimegoogle-adkfloor to a fixed 1.x release, refreshpython/uv.lock, and update the ADK Python template pinVerification
make lintuv run pytest packages/kagent-adk/tests/unittests/converters/test_consts_sync.py