Makefile fixup help#1898
Merged
Merged
Conversation
marcofranssen
requested review from
EItanya,
ilackarms,
peterj and
yuval-k
as code owners
marcofranssen
force-pushed
the
fix-makefile-docs
branch
from
27505bc to
85b92fd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Improves contributor ergonomics by making make help accurately list and categorize available Make targets, with consistent ## descriptions and ##@ section headers.
Changes:
- Expanded
make helpformatting (wider target column) and added##descriptions to many existing targets so they appear in help output. - Promoted
print-tools-versionsinto the help-visible target list. - Added/organized help categories (
##@ ...) across Build/Testing/Cluster/Helm/Dev/Security sections.
Comments suppressed due to low confidence (1)
Makefile:146
check-api-keyis a command-style target but isn’t marked phony. Add.PHONY: check-api-keyso it always runs even if acheck-api-keyfile ever exists in the workspace.
check-api-key: ## Validate required API key for the configured model provider
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcofranssen
force-pushed
the
fix-makefile-docs
branch
from
a779e82 to
757f986
Compare
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
force-pushed
the
fix-makefile-docs
branch
from
757f986 to
392f16e
Compare
EItanya
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems the AI that generated the makefile didn't utilize the help task.
This PR fixes that up so it is easier for contributors to see what make tasks are available.
Now when running
or
make helpall available tasks show up as documented.
Note
Some tasks moved location to make them render nicely under the specific sections.