fix(ui): show empty state when no model configs exist (#1930)#1944
Merged
peterj merged 2 commits intoMay 29, 2026
Conversation
Signed-off-by: gauravshinde1729 <shindegauravpict@gmail.com>
Signed-off-by: gauravshinde1729 <shindegauravpict@gmail.com>
peterj
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
fix(ui): show empty state when no model configs exist (#1930)
Description:
What
When no
ModelConfigresources are deployed, the UI showed a"Failed to fetch models" error instead of rendering the normal empty
state ("no agents yet" / empty models page).
Fixes #1930
Why
The backend's
StandardResponse.Datafield usesjson:"data,omitempty",so an empty list serializes with the
datafield omitted entirely(e.g.
{"error":false,"message":"Successfully listed ModelConfigs"}),returned with HTTP 200.
The UI treated a missing
dataas a fetch failure:So a valid "zero model configs" response was misread as an error and
surfaced via the shared error state in AgentsProvider (and on the
/models page).
Change
Treat a missing/empty list as a valid empty result, and only fail on an
explicit response.error — matching the existing defensive pattern in
AgentList (result.data || []):
This is a frontend-only fix; the backend omitempty behavior is
unchanged.
Screenshots
Before:
After: