Conversation
Signed-off-by: justinmacnair <justinmacnair@gmail.com>
huang195
requested changes
Mar 19, 2026
Contributor
huang195
left a comment
huang195
left a comment
There was a problem hiding this comment.
Thanks for fixing the 404! The root cause is correct — href="/" resolves to https://kagenti.github.io/ which doesn't exist.
However, converting the logo to a non-clickable <span> removes standard homepage navigation UX. A better fix is to use href="./" which resolves correctly on GitHub Pages (stays within the /.github/ subpath) while keeping the logo clickable.
Also, the .vscode/settings.json changes and .gitignore addition are contradictory — adding .vscode/ to gitignore means the settings.json changes won't be trackable going forward. Consider separating these into their own PR or picking one approach.
…rofile readme. Untracked settings. Signed-off-by: justinmacnair <justinmacnair@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
#50
(Optional) Testing Instructions
Fixes #