Fix Dockerfiles to use fully qualified image names for Podman compatibility#125
Merged
Fix Dockerfiles to use fully qualified image names for Podman compatibility#125
Conversation
… compatibility Shipwright builds using Buildah/Podman fail when Dockerfiles use short image names (e.g., `golang:...`) because Podman enforces fully qualified names and cannot prompt for registry selection in non-interactive environments like build pods. Prefix all short FROM image references with `docker.io/library/` so builds work with both Docker and Podman. Fixes #123 Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Dockerfiles to use fully qualified image names (prefixed with docker.io/library/) instead of short names to fix Shipwright builds that use Buildah/Podman. These container runtimes enforce fully qualified names in non-interactive environments and fail when encountering short names like python:3.12-slim-bookworm.
Changes:
- Update FROM statements in 4 Dockerfiles to use fully qualified image names with
docker.io/library/prefix - Remove trailing newline in
mcp/shopping_tool/Dockerfile
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mcp/weather_tool/Dockerfile | Update FROM to use docker.io/library/python:3.12-slim-bookworm |
| mcp/shopping_tool/Dockerfile | Update FROM to use docker.io/library/python:3.11-slim and remove trailing newline |
| mcp/github_tool/Dockerfile | Update FROM to use docker.io/library/golang:1.24.9-bookworm |
| a2a/weather_service/Dockerfile | Update FROM to use docker.io/library/python:3.12-slim-bookworm |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker.io/library/...) in all Dockerfiles that previously used short namesProblem
Shipwright builds fail with:
Changes
mcp/github_tool/Dockerfilegolang:1.24.9-bookwormdocker.io/library/golang:1.24.9-bookwormmcp/weather_tool/Dockerfilepython:3.12-slim-bookwormdocker.io/library/python:3.12-slim-bookwormmcp/shopping_tool/Dockerfilepython:3.11-slimdocker.io/library/python:3.11-slima2a/weather_service/Dockerfilepython:3.12-slim-bookwormdocker.io/library/python:3.12-slim-bookwormAll other Dockerfiles already use fully qualified names (e.g.,
ghcr.io/astral-sh/uv:...).Fixes #123
Test plan
mcp/github_toolwith Podman-based build strategy