fix the problem where slack_tool listens to 127.0.0.1#39
Merged
maia-iyer merged 1 commit intokagenti:mainfrom Aug 20, 2025
Merged
fix the problem where slack_tool listens to 127.0.0.1#39maia-iyer merged 1 commit intokagenti:mainfrom
maia-iyer merged 1 commit intokagenti:mainfrom
Conversation
other pods to connect to it Signed-off-by: Hai Huang <huang195@gmail.com>
huang195
force-pushed
the
slack_tool_use_0000
branch
from
1fa7047 to
73e7d2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on slack, new FASTMCP library seems to default to 127.0.0.1 when host is not specified, which is not what we want. We should explicitly specify 0.0.0.0, so other pods in the cluster can reach our mcp servers. This PR also fixes this problem for weather_tool as well.