Conversation
- Add kagenti-ci.yml workflow with Go build, golangci-lint, and unit/gRPC test jobs on ubuntu-latest - Triggers on PRs to main/mvp and pushes to mvp - Update README with fork notice and upstream tracking info Closes kagenti/kagenti#1352 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
- Replace empty error branch with explicit discard in contract_test.go - Increase golangci-lint timeout to 5m (default 1m was insufficient) Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
…iner
Adapts the forked openshell-driver-openshift for multi-tenant MVP:
- --namespace flag: already present; --tenant flag added (defaults to
namespace value) to set openshell.ai/tenant and kagenti.io/team labels
on all sandbox CR metadata and pod template labels
- dtach binary: init container command updated to sh -c so it copies
both openshell-sandbox and dtach from the supervisor image into the
shared emptyDir volume; --dtach-binary-path flag configures the source
path (default: /usr/local/bin/dtach)
- Scoped RBAC: deploy/gateway-with-driver.yaml replaces the cluster-admin
ClusterRoleBinding with a namespace-scoped Role + RoleBinding; all
namespace references parameterized via ${NAMESPACE} envsubst variable
Closes #1354
Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapts the forked
openshell-driver-openshiftfor multi-tenant MVP — addresses all four changes from kagenti/kagenti#1354.--namespaceflag was already present; driver targets one namespace per tenant--tenantflag (defaults to namespace value) injectsopenshell.ai/tenantandkagenti.io/teamlabels on Sandbox CRs and pod template metadatacptosh -c "cp supervisor && cp dtach"so both binaries land in the shared emptyDir volume; configurable via--dtach-binary-pathdeploy/gateway-with-driver.yamlreplacesClusterRoleBinding + cluster-adminwith namespace-scopedRole + RoleBinding; all namespace references parameterized via${NAMESPACE}forenvsubstAcceptance criteria
--namespace team1flag targets sandbox creation toteam1namespace onlyopenshell.ai/tenantandkagenti.io/teamlabelsRole, notClusterRoleopenshell-sandboxanddtachbinariesTest plan
go test ./...)TestDefaultConfigupdated to verifyDtachBinaryPathdefaultTestBuildSandboxSpec_SupervisorInitContainerupdated to verifysh -ccommand includes both binary pathsTestBuildSandboxSpec_Labelsupdated to assert no tenant labels whenTenantis emptyTestBuildSandboxSpec_TenantLabelsadded — verifiesopenshell.ai/tenantandkagenti.io/teamare set whencfg.Tenant = "team1"🤖 Generated with Claude Code