Conversation
Complete CI baseline for the repo: - .github/dependabot.yml: weekly updates for GitHub Actions, Python dependencies (root + nemocheck plugin), and Docker base image - .github/workflows/scorecard.yml: OpenSSF Scorecard on push to main and weekly schedule; publishes results to GitHub Security tab - .github/workflows/build.yml: multi-arch (amd64+arm64) container image build and push to ghcr.io on tag push or manual trigger; supports optional PLUGIN_DEPS build-arg for baking in specific plugins - .github/workflows/ci.yaml: add timeout-minutes: 15 to prevent hung jobs All actions SHA-pinned (no tag-only references). Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
evaline-ju
left a comment
There was a problem hiding this comment.
The build is a bit complicated for this repo currently but the other additions lgtm - perhaps we could leave that off for now?
There was a problem hiding this comment.
I'm currently testing a parallel of this (though not as generic) - image building here requires building some envoy protos which we've kept separately from the Dockerfile for now since the Python compilation was pretty messy
The multi-arch container build workflow is not needed at this stage. Remove it per evaline-ju's suggestion in PR review. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
pdettori
left a comment
There was a problem hiding this comment.
Good call — removed build.yml in the latest commit. The PR now only contains dependabot.yml, scorecard.yml, and the timeout-minutes addition to ci.yaml.
There was a problem hiding this comment.
let's update the kagenti/maintainers reviewers with the new kagenti/plugin-adapters-maintainers group like in #73
There was a problem hiding this comment.
Is this resolved? I don't think I have permissions to see group memembership.
There was a problem hiding this comment.
@julianstephen I see you in the expected group now
Address review feedback: use repo-specific team instead of org-wide maintainers group, consistent with PR #73. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
|
Addressed review feedback:
|
Summary
Phase 4 of repo orchestration — completes the CI baseline. The repo already has strong
ci.yamlandsecurity-scans.yamlworkflows; this PR fills the remaining gaps.New files:
.github/dependabot.yml: weekly automated dependency updates for:pyproject.tomlplugins/examples/nemocheck/pyproject.tomlDockerfilebase image.github/workflows/scorecard.yml: OpenSSF Scorecard analysismain+ weekly Monday scheduleModified:
.github/workflows/ci.yaml: addtimeout-minutes: 15to prevent hung CI jobsWhat was already in place (not changed)
ci.yamlsecurity-scans.yamlstale.yamlself-assign.ymlTest plan