Added manager shutdown after grpc termination#95
Closed
julianstephen wants to merge 2 commits intokagenti:mainfrom
Closed
Added manager shutdown after grpc termination#95julianstephen wants to merge 2 commits intokagenti:mainfrom
julianstephen wants to merge 2 commits intokagenti:mainfrom
Conversation
Signed-off-by: julianstephen <julian.stephen@gmail.com>
Signed-off-by: julianstephen <julian.stephen@gmail.com>
evaline-ju
reviewed
Apr 9, 2026
| await server.start() | ||
| # wait forever | ||
| await server.wait_for_termination() | ||
| await manager.shutdown() |
Contributor
There was a problem hiding this comment.
Would we want wait_for_termination() in try/finally to ensure this new line runs on all exit paths (SIGTERM, KeyboardInterrupt, unexpected errors), not just graceful termination?
Collaborator
Author
|
Superseded by pull #96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Towards a fix for #25. Added manager shutdown after grpc server termination. If this is due to an issue in the cpex side, this should fix it. This new line should shuts down registered plugins, clear the plugin registry and clean up state.
Tested by repeatedly restarting plugins-adapter pod. Tried 5 times in a row without issues. 🤞