Skip to content

Added Osu username validation#14

Merged
kaifcodec merged 1 commit intokaifcodec:mainfrom
jaduplansti:feature/osu-module
Nov 9, 2025
Merged

Added Osu username validation#14
kaifcodec merged 1 commit intokaifcodec:mainfrom
jaduplansti:feature/osu-module

Conversation

@jaduplansti
Copy link
Copy Markdown
Contributor

it works pretty straightforward:

  1. request from https://osu.ppy.sh/users/{name}

  2. check the status code

@kaifcodec
Copy link
Copy Markdown
Owner

Nice work, the osu module looks solid and fits perfectly with the project’s structure and guidelines. Appreciate the attention to detail.

If you’re up for it, feel free to take a look at issues #12 and #13 next, they’d both benefit from your touch.

@kaifcodec kaifcodec merged commit d6b16c5 into kaifcodec:main Nov 9, 2025
@kaifcodec
Copy link
Copy Markdown
Owner

Hey @jaduplansti, just a heads-up, your commit didn’t show up in the contributors list because the author email in the commit was set as . GitHub can’t link it to your profile unless it matches one of your verified emails.

If you want to appear in the contributors tab next time, run this before your next commit:

git config --global user.email "yourusername@users.noreply.github.com"

Or even you can commit an empty changes next from your main branch maybe in README i will merge it.

Everything else about your PR was perfect, thanks again for the clean osu module!

@jaduplansti jaduplansti deleted the feature/osu-module branch November 9, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants