Skip to content

fix: refine Netflix module logic and add to LOUD_MODULES#273

Merged
kaifcodec merged 6 commits into
kaifcodec:mainfrom
shredzwho:fix/netflix-loud-module
Mar 4, 2026
Merged

fix: refine Netflix module logic and add to LOUD_MODULES#273
kaifcodec merged 6 commits into
kaifcodec:mainfrom
shredzwho:fix/netflix-loud-module

Conversation

@shredzwho
Copy link
Copy Markdown
Contributor

Description

This PR addresses issue #262 by refining the Netflix module's detection logic to prevent false negatives.

Changes Made

  • Journey Node Switch: Changed inputUserJourneyNode from LOGIN to WELCOME. The LOGIN node was found to return a password field for both registered and unregistered accounts, making it unreliable.
  • Strict Keyword Matching: Implemented explicit checks for "Welcome back!" (Registered) and "sign-up link"/"create your account" (Available).
  • Security Check: Added netflix to LOUD_MODULES in helpers.py to ensure users are not spammed with verification codes unless --allow-loud is explicitly used.
  • Robustness: Integrated get_random_user_agent() and mandatory headers for session stability.

Verification

  • Verified with known registered email: detected correctly as Registered.
  • Verified with random unregistered email: detected correctly as Not Registered.

SylvainM98 and others added 4 commits March 2, 2026 21:45
The Netflix module (CLCSWebInitSignup GraphQL mutation) triggers a real
verification code sent to the scanned email address. This notifies the
target, so Netflix should be skipped by default like other loud modules.

Discovered during testing: each scan triggered an unsolicited Netflix
verification code to the target email.
- Switch to LOGIN node to reduce target notifications
- Fix locale from en-IN to en-US for global compatibility
- Fix session URL from netflix.com/in/ to netflix.com/
- Simplify detection to single reliable marker
- Add GraphQL error guard to prevent false negatives
- Increase timeout from 5s to 10s
Comment thread user_scanner/email_scan/entertainment/netflix.py Outdated
@json-hunter07
Copy link
Copy Markdown
Collaborator

LGTM as well. @kaifcodec

@kaifcodec kaifcodec merged commit 5997af2 into kaifcodec:main Mar 4, 2026
2 checks passed
@kaifcodec kaifcodec added the bug fix Fixed a bug in existing files label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix Fixed a bug in existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants