added automatic version pulling from py toml to the nix flake#384
Open
BoxC4T wants to merge 1 commit into
Open
added automatic version pulling from py toml to the nix flake#384BoxC4T wants to merge 1 commit into
BoxC4T wants to merge 1 commit into
Conversation
Owner
|
@BoxC4T Thank you for opening the PR. I already had this feature in mind. I’ve just been holding off because I want (or need) to keep updating the file manually for a little while longer before automating it. I’ll most likely merge this after the next version bump ( One thing I noticed, both in this PR and PR #360, is that your commit messages aren’t using conventional commit types (e.g. I’d recommend reopening this PR with a properly typed commit message. For example:
That way, we can merge it directly from your branch (without needing to squash it) and keep the commit history consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found the function to pull from a toml. This should mean the only times that changes to the flake are required would be a change in file struct or dependancys