Skip to content

added automatic version pulling from py toml to the nix flake#384

Open
BoxC4T wants to merge 1 commit into
kaifcodec:mainfrom
BoxC4T:master
Open

added automatic version pulling from py toml to the nix flake#384
BoxC4T wants to merge 1 commit into
kaifcodec:mainfrom
BoxC4T:master

Conversation

@BoxC4T

@BoxC4T BoxC4T commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

found the function to pull from a toml. This should mean the only times that changes to the flake are required would be a change in file struct or dependancys

@kaifcodec

kaifcodec commented Jun 22, 2026

Copy link
Copy Markdown
Owner

@BoxC4T Thank you for opening the PR.

I already had this feature in mind. I’ve just been holding off because I want (or need) to keep updating the file manually for a little while longer before automating it. I’ll most likely merge this after the next version bump (v1.4.0.3).

One thing I noticed, both in this PR and PR #360, is that your commit messages aren’t using conventional commit types (e.g. feat, fix, refactor, etc.).

I’d recommend reopening this PR with a properly typed commit message. For example:

  • feat: add automatic version pulling from pyproject.toml to flake.nix
  • refactor(flake.nix): automatically pull version from pyproject.toml

That way, we can merge it directly from your branch (without needing to squash it) and keep the commit history consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants