Skip to content

fix(git): re-enable --no-separator for git notes append#691

Merged
kaihowl merged 1 commit into
masterfrom
claude/open-issues-review-tdogU
May 24, 2026
Merged

fix(git): re-enable --no-separator for git notes append#691
kaihowl merged 1 commit into
masterfrom
claude/open-issues-review-tdogU

Conversation

@kaihowl
Copy link
Copy Markdown
Owner

@kaihowl kaihowl commented May 24, 2026

Summary

Background

--no-separator was disabled in #97 (Jan 2024) because it was not available in the git versions supported at the time. The minimum required git version has since been raised to 2.43.0, while --no-separator has been available since git 2.39.0 — so it is now safe to enable unconditionally.

Without the flag, git notes append inserts a blank line between each appended note entry. The deserialize function already filtered these empty lines, so correctness was never affected, but the notes contained unnecessary whitespace. With the flag, notes are compact and contain no separator lines.

Test plan

  • cargo fmt — no changes
  • cargo clippy — clean
  • cargo nextest run -- --skip slow --skip test_remove — 360/360 passed (test_remove requires libfaketime, pre-existing skip)
  • Mutation testing: 1 mutant found, 1 caught (exit 0)

https://claude.ai/code/session_01DtkUkKjwP4tm1QHEQff3zV


Generated by Claude Code

--no-separator was disabled in #97 due to incompatibility with older git
versions. The minimum required git version is now 2.43.0, while
--no-separator has been available since 2.39.0, so it is safe to enable.

Closes #96

https://claude.ai/code/session_01DtkUkKjwP4tm1QHEQff3zV
@github-actions
Copy link
Copy Markdown
Contributor

Performance Report

Performance Results

Audit Results

Auditing measurement "add-benchmark" (os=ubuntu-22.04/rust=beta):
  ✅ 'add-benchmark'
  Aggregation: min
  z-score (mad): ↑ 2.17
  Head: μ: 24ms σ: N/A MAD: 0ns n: 1
  Tail: μ: 18.9ms σ: 3.4ms MAD: 2.3ms n: 11
   [-26.66% – +20.06%] ▇▁▁▁█▇▅▁▅▅▅█

Auditing measurement "add-benchmark" (os=ubuntu-22.04/rust=stable):
  ⏭️ 'add-benchmark'
  Only 8 historical measurements found. Less than requested min_measurements of 10. Skipping test.
  Aggregation: min
  z-score (mad): ↑ 0.74
  Head: μ: 22.3ms σ: N/A MAD: 0ns n: 1
  Tail: μ: 20.4ms σ: 3.9ms MAD: 2.6ms n: 8
   [-30.87% – +17.55%] █▇█▁▅▅▅▁▆

Auditing measurement "release-binary-size" (os=ubuntu-22.04/rust=stable):
  ✅ 'release-binary-size'
  Aggregation: min
  z-score (stddev): ↑ 2.12
  Head: μ: 8.2MB σ: N/A MAD: 0B n: 1
  Tail: μ: 8.1MB σ: 66.1kB MAD: 37.6kB n: 34
   [-0.70% – +1.92%] █▇▇▇▇▇▃▄▄▄▄▄▄▃▃▃▃▃▃▃▃▃▃▃▁▁▁▁▁▁▁▁▁▁█

Auditing measurement "report" (os=ubuntu-22.04/rust=beta):
  ✅ 'report'
  Aggregation: min
  z-score (stddev): ↑ 2.01
  Head: μ: 29.5ms σ: N/A MAD: 0ns n: 1
  Tail: μ: 22.8ms σ: 3.3ms MAD: 552µs n: 35
   [-27.93% – +21.97%] ▇▂▂▂█▇▅▁▅▅▅▅▅▅▅▅▆▂▁▅▅▅▅▁▂▅▅▅▅▅▁▂▆▅▁█

Auditing measurement "report" (os=ubuntu-22.04/rust=stable):
  ✅ 'report'
  Aggregation: min
  z-score (stddev): ↑ 0.99
  Head: μ: 27ms σ: N/A MAD: 0ns n: 1
  Tail: μ: 24.1ms σ: 3ms MAD: 586µs n: 32
   [-29.29% – +22.67%] █▇█▁▆▅▆▁▅▅▂▅▅▂▆▅▁▅▅▅▅▅▅▅▅▅▅▅▅▅▅▅▆

Auditing measurement "report-benchmark" (os=ubuntu-22.04/rust=beta):
  ✅ 'report-benchmark'
  Aggregation: min
  z-score (stddev): ↑ 1.46
  Head: μ: 29.3ms σ: N/A MAD: 0ns n: 1
  Tail: μ: 23.3ms σ: 4.1ms MAD: 3ms n: 11
   [-25.39% – +20.27%] ▇▁▁▁█▇▅▁▅▅▅█

Auditing measurement "report-benchmark" (os=ubuntu-22.04/rust=stable):
  ⏭️ 'report-benchmark'
  Only 8 historical measurements found. Less than requested min_measurements of 10. Skipping test.
  Aggregation: min
  z-score (stddev): ↑ 0.49
  Head: μ: 27.1ms σ: N/A MAD: 0ns n: 1
  Tail: μ: 24.8ms σ: 4.6ms MAD: 3.1ms n: 8
   [-29.96% – +17.26%] █▇█▁▅▅▅▁▆

Auditing measurement "report-size" (os=ubuntu-22.04/rust=beta):
  ✅ 'report-size'
  Aggregation: min
  z-score (stddev): ↑ 0.91
  Head: μ: 20.3kB σ: N/A MAD: 0B n: 1
  Tail: μ: 17.6kB σ: 3kB MAD: 0B n: 35
   [-38.14% – +0.00%] ██████████████████▄▄▄▄▄▄▄▄▄▄▄▄▁▁▁▁▁█

Auditing measurement "report-size" (os=ubuntu-22.04/rust=stable):
  ✅ 'report-size'
  Aggregation: min
  z-score (stddev): ↑ 0.99
  Head: μ: 20.3kB σ: N/A MAD: 0B n: 1
  Tail: μ: 17.3kB σ: 3.1kB MAD: 2.9kB n: 32
   [-18.78% – +31.30%] ███████████████▄▄▄▄▄▄▄▄▄▄▄▄▁▁▁▁▁█

Auditing measurement "report-size-benchmark" (os=ubuntu-22.04/rust=beta):
  ✅ 'report-size-benchmark'
  Aggregation: median
  z-score (stddev): →
  Head: μ: 20.3kB σ: N/A MAD: 0B n: 1
  Tail: μ: 20.3kB σ: 0B MAD: 0B n: 18
   [+0.00% – +0.00%] ▅▅▅▅▅▅▅▅▅▅▅▅▅▅▅▅▅▅▅

Auditing measurement "report-size-benchmark" (os=ubuntu-22.04/rust=stable):
  ✅ 'report-size-benchmark'
  Aggregation: median
  z-score (stddev): →
  Head: μ: 20.3kB σ: N/A MAD: 0B n: 1
  Tail: μ: 20.3kB σ: 0B MAD: 0B n: 15
   [+0.00% – +0.00%] ▅▅▅▅▅▅▅▅▅▅▅▅▅▅▅▅

Overall: PASSED (11/11 groups passed)

Measurement Storage Size

Live Measurement Size Report
============================

⚠️  Shallow clone detected - measurement counts may be incomplete (see FAQ)

Number of commits with measurements: 313
Total measurement data size (on-disk (compressed)): 429.2kB

Repository Statistics (for context):
-------------------------------------
  Loose objects: 0 (0B)
  Packed objects: 5655 (2.2MB)
  Total repository size: 2.2MB

Created by git-perf

@github-actions
Copy link
Copy Markdown
Contributor

🧬 PR Mutation Testing Results

Status: ✅ All mutants caught - excellent test coverage!

Mutation Testing Metrics (Changed Code Only)

Metric Count
Total Mutants 1
✅ Caught 1
❌ Missed 0
⏱️ Timeout 0
🚫 Unviable 0

Mutation Score: 100.0% (1/1 viable mutants caught)

✅ Great Job!

All mutants in your changes were caught by the test suite. Your code is well-tested!


Incremental mutation testing only tests code modified in this PR.
Full mutation testing runs weekly to catch issues in unchanged code.

📦 Artifacts

Download full mutation report

@kaihowl kaihowl marked this pull request as ready for review May 24, 2026 17:00
@kaihowl kaihowl merged commit f9146b3 into master May 24, 2026
25 checks passed
@kaihowl kaihowl deleted the claude/open-issues-review-tdogU branch May 24, 2026 17:00
@release-plz-token release-plz-token Bot mentioned this pull request May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

readd no-separator option

2 participants