fix(git): re-enable --no-separator for git notes append#691
Merged
Conversation
--no-separator was disabled in #97 due to incompatibility with older git versions. The minimum required git version is now 2.43.0, while --no-separator has been available since 2.39.0, so it is safe to enable. Closes #96 https://claude.ai/code/session_01DtkUkKjwP4tm1QHEQff3zV
Contributor
Performance ReportAudit ResultsMeasurement Storage SizeCreated by git-perf |
Contributor
🧬 PR Mutation Testing ResultsStatus: ✅ All mutants caught - excellent test coverage! Mutation Testing Metrics (Changed Code Only)
Mutation Score: 100.0% (1/1 viable mutants caught) ✅ Great Job!All mutants in your changes were caught by the test suite. Your code is well-tested! Incremental mutation testing only tests code modified in this PR. 📦 Artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-separatorto thegit notes appendcall inraw_add_note_lineBackground
--no-separatorwas disabled in #97 (Jan 2024) because it was not available in the git versions supported at the time. The minimum required git version has since been raised to 2.43.0, while--no-separatorhas been available since git 2.39.0 — so it is now safe to enable unconditionally.Without the flag,
git notes appendinserts a blank line between each appended note entry. Thedeserializefunction already filtered these empty lines, so correctness was never affected, but the notes contained unnecessary whitespace. With the flag, notes are compact and contain no separator lines.Test plan
cargo fmt— no changescargo clippy— cleancargo nextest run -- --skip slow --skip test_remove— 360/360 passed (test_removerequireslibfaketime, pre-existing skip)https://claude.ai/code/session_01DtkUkKjwP4tm1QHEQff3zV
Generated by Claude Code