Add output to GCE/Azure #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itxaka <itxaka@kairos.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 15.42% 15.42%
=======================================
Files 10 10
Lines 1621 1621
=======================================
Hits 250 250
Misses 1355 1355
Partials 16 16 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Itxaka <itxaka@kairos.io>
Merged
jimmykarily
approved these changes
Jan 2, 2025
Contributor
jimmykarily
left a comment
jimmykarily
left a comment
There was a problem hiding this comment.
Good job!
We should create some new commands in Auroraboot to expose these. Now they are only usable through the base command (the "declarative" one).
| func Raw2Azure(source string) (string, error) { | ||
| internal.Log.Logger.Info().Str("source", source).Msg("Converting raw disk to Azure VHD") | ||
| name := fmt.Sprintf("%s.vhd", source) | ||
| // Copy raw to new image with VHD appended |
Contributor
There was a problem hiding this comment.
Not "copying" since there is only one copy of the file at any time.
Suggested change
| // Copy raw to new image with VHD appended |
| Reserved [427]byte // This field contains zeroes. | ||
| } | ||
|
|
||
| // Lots of magic numbers here, but they are all defined in the VHD format spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.