106/add port forward config#107
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Issue #106（オブジェクトストレージの Filer UI を SSH port-forward で localhost から閲覧可能にする）に関連して、Docker Compose のポート公開設定と、手動デプロイ workflow の deploy_ref 解決ロジックを調整する PR です。
Changes:
- staging/test/production の Compose オーバーレイにポート公開（kaede: 8080、seaweedfs: 8888）を追加
- SeaweedFS の Filer UI ポート（8888）を
127.0.0.1バインドで公開（ssh port-forward 前提） - test/stg のデプロイ workflow で、deploy_ref 未指定時に「現在のブランチ」をデフォルトにする
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| compose.test.yml | kaede(8080) と seaweedfs(8888) のポート公開を追加 |
| compose.staging.yml | kaede(8080) と seaweedfs(8888) のポート公開を追加 |
| compose.production.yml | kaede(8080) と seaweedfs(8888) のポート公開を追加 |
| .github/workflows/okarin-test-deploy-ci.yml | deploy_ref 未指定時に github.ref_name を使うよう変更 |
| .github/workflows/okarin-stg-deploy-ci.yml | deploy_ref 未指定時に github.ref_name を使うよう変更 |
| - ${KAEDE_ENV_FILE:-./deploy/apps/kaede.test.env} | ||
| - ${DEPLOY_META_FILE:-/var/tmp/okarin/runtime/test.env} | ||
| ports: | ||
| - "8080:8080" |
| - ${KAEDE_ENV_FILE:-./deploy/apps/kaede.staging.env} | ||
| - ${DEPLOY_META_FILE:-/var/tmp/okarin/runtime/staging.env} | ||
| ports: | ||
| - "8080:8080" |
| - ${KAEDE_ENV_FILE:-./deploy/apps/kaede.production.env} | ||
| - ${DEPLOY_META_FILE:-/var/tmp/okarin/runtime/production.env} | ||
| ports: | ||
| - "8080:8080" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue番号
変更内容(写真か動画も一緒に)
ローカルでsshを行って特定のポートにアクセスできるように変更する
影響範囲(あれば)