Conversation
This introduces an automatic pull request labeler using GitHub Actions to streamline workflow management.
This ensures that labels remain consistent by automatically syncing them.
Introduce a CI pipeline using GitHub Actions to automate builds, tests, and test report summarization.
This simplifies the workflow by limiting triggers to push events only.
Standardize and clarify job naming to improve readability.
Enable better control over cache modifications by adding the cache-read-only parameter.
Optimize build performance by enabling Gradle caching in the configuration.
Expand labeler configuration by adding categories for build, core, engine, platform, server, and website changes.
Add new categories for CI/CD, documentation, and test changes to enhance labeling granularity.
|
@dosu Can you review this PR? |
|
Here's what I found: the only CI workflow currently in the repository is for website deployment via GitHub Pages, which runs build steps for the website but does not cover general build, test, lint, or labeler automation for the main codebase. The minimal CI pipeline (build, test, lint) is explicitly listed as a required task for the initial open-source release, and the project plans to use actions/labeler for short-term labeling automation, with a long-term goal of adopting AI-native tools like DosuBot for richer automation and PR feedback. If this PR adds a minimal CI workflow with build, test, and labeler steps as described, it aligns well with both the project's roadmap and best practices seen in projects like Apache Spark and slatedb/slatedb. I recommend confirming that the workflow includes at least: a build job for the main codebase, a test job (even if minimal), linting (if applicable), and a labeler configuration. This will ensure stable, repeatable merges and help with early contributor onboarding. If any of these are missing, consider adding them to match the project's stated goals and community standards. References:
To reply, just mention @dosu. How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other |
|
@dosu Can you add labels to this PR? |
|
There isn’t an automated labeler or label configuration set up in this repo yet, so labels need to be added manually. For this PR, which introduces a minimal CI workflow, I recommend using standard labels like ci, github-actions, and workflow. These are common for changes related to continuous integration and GitHub Actions setup. If you want to establish a convention, these would be a good starting point. To reply, just mention @dosu. How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other |
|
From a brief offline discussion between @em3s and @eazyhozy, we are sharing a short summary here for transparency. Current state
Plan and direction
|
|
Please remove the rule-based labeler from this PR and keep the scope focused on the minimal CI setup. |
Delete labeler.yml and pr-labeler.yml to simplify the repository and reduce maintenance overhead.
|
@em3s This PR enables Gradle build cache via Please review whether this is appropriate as a default setting for the project, and let me know if there are any concerns regarding cache safety or CI behavior. |
|
@dosu please update your previous review #11 (comment). |
|
The PR now focuses only on a minimal CI workflow with Gradle cache enabled, and the rule-based labeler scripts have been removed as requested. Enabling To reply, just mention @dosu. How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other |
em3s
left a comment
There was a problem hiding this comment.
LGTM 👍
I checked the workflow run:
https://github.com/kakao/actionbase/actions/runs/20767979252
Everything works as expected. The PR is well-scoped to a minimal CI setup.
|
I’ve already approved this PR 👍 Before merging, could you please make a small adjustment to align with the intended CI scope?
A possible configuration would be: on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
types:
- opened
- reopened
- synchronize
- ready_for_review |
Add branch-specific triggers for `push` and `pull_request` events, and include conditions to skip draft pull requests.
|
Thanks for the suggestion. on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
types:
- opened
- reopened
- synchronize
- ready_for_review
jobs:
build:
if: >
github.event_name == 'push' ||
(github.event_name == 'pull_request' && github.event.pull_request.draft == false) |
|
LGTM 👍 |
Summary
This PR introduces a minimal GitHub Actions CI workflow to ensure stable and repeatable merges in the early stage of the open-source project.
Result (edited)
Based on feedback in #11 (comment), the
actions/labelerscripts were removed.This PR includes only:
Referrer