Backport storage-ops shadow testing to 0.2.x#262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports the storage-ops shadow-testing feature to the v0.2.x line for the v0.2.1 release. Cherry-picks four squash-merged main commits in order: #258 -> #259 -> #261 -> #254.
With the
AB-Include-Mutation-Context: trueheader, mutation responses surface the HBasePut/Delete/Incrementops actually issued to storage undercontext["storageOps"], base64-encoded. Without the header the wire format is unchanged.Cherry-picked commits
3692c41context: Map<String, Any>?on V2 / V3 mutation response items1ef1b6dAB-Include-Mutation-Contextheader + e2e non-breaking verification5e97d9bStorageOpCollectorscaffold + mutation-path wiring9bfa878collect()implementation forPut/Delete/Increment+ testsConflict resolution
All conflicts landed in #261 and were limited to the import region — 0.2.x does not have main's post-v0.2.0 refactors (
engine.sql.DataFrame,engine.query.LabelProvider, etc.). Resolved by keeping the 0.2.x imports as-is and adding only theStorageOpCollectorimport. No behavioral changes beyond what the four upstream commits define.Affected files:
engine/binding/TableBinding.ktv2/engine/Graph.ktv2/engine/v3/NilTableBinding.ktv2/engine/v3/V2BackedTableBinding.ktTest plan
./gradlew buildlocally passed. Key suites:StorageOpCollectorTest— round-trip per op type, multi-CF Put, multi-byte value, truncation,Append→Unknown, non-MutationfallthroughCdcContextSerializationTest—storageOps/storageOpsTruncatedexcluded from CDC JSONV2EdgeStorageOpsSpec— V2/graph/v2/edgewith / without headerEdgeMutationStorageOpsSpec— V3 edge + multi-edge with headerMutationResultItemContextTest,MutationContextOptInE2ETest— context field shape and opt-in gating