Merged
Conversation
Introduces a SegmentStatus enum to track segment lifecycle (InProgress, Committed, Tombstone) in manifest metadata, replacing the previous tombstone boolean. Updates segment creation and flush logic to use the new status, adds helper methods for lifecycle transitions, and extends tests for segment status and serde. Also adds a ManifestPendingWriteIdx partition, improves ScalarValue handling, and updates manifest service and flush helpers for the new model.
Updated all integration and scenario tests to generate unique usernames by prefixing them with the test namespace. This prevents data collisions and interference when tests are run in parallel, especially for USER tables partitioned by user_id. Also improved test reliability by adding retries for inserts during flushes and made minor test infrastructure improvements.
Introduces multipart/form-data handling for SQL endpoints, enabling file uploads via FILE("name") placeholders. Adds file download handler with user impersonation and permission checks, updates dependencies, and provides utility functions for file staging and SQL placeholder substitution. Includes new tests and documentation for file datatype support.
Replaces basic auth with JWT bearer tokens in file permission tests, ensuring user IDs are used consistently. Updates test setup to use unique user and namespace IDs, adds retries and delays for cluster propagation, and improves CLI config test robustness. Also prevents auto-starting the test server inside an existing tokio runtime to avoid runtime conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several dependency updates and project structure documentation improvements, as well as minor code changes to simplify username handling in authentication endpoints. The most significant changes are the expansion of the workspace/project structure, new and updated dependencies (notably for multipart HTTP support and cryptography), and simplification of username conversion logic in the API.
Dependency and Feature Additions:
kalamdb-filestore,kalamdb-session, andkalamdb-configs. [1] [2]multipartfeature inreqwestand added theactix-multipartcrate to support multipart HTTP requests (e.g., file uploads). [1] [2] [3]jsonwebtokencrate to use theaws_lc_rsfeature for cryptography, likely for better compatibility or security.sha2crate for hashing needs and updated several other dependencies to newer versions. [1] [2]Project Structure and Documentation:
AGENTS.mdproject structure section to reflect the expanded modular architecture and clarify the responsibilities of each crate.Authentication Endpoint Simplification:
login_handler,refresh_handler, andme_handlerby using the username string directly, rather than converting it to a typedUserName. [1] [2] [3]Notes and Planning:
Notes.mdfor upcoming features and bug fixes, including system columns options, SQL error handling, and file permission checks.