Conversation
Add request tracing improvements and make smoke tests more robust and less flaky. - backend/crates/kalamdb-core/src/sql/executor/handler_registry.rs: Instrument async handler execution with tracing::Instrument so SQL handler spans are properly attached. - backend/src/lifecycle.rs: Add KalamDbRootSpanBuilder to force parent: None for HTTP request root spans and switch TracingLogger to use it (prevents cross-request span contamination with OTel/Jaeger). - backend/tests/common/testserver/http_server.rs: Avoid holding/propagating the global test-server lock in the HttpTestServer struct (use temporary variable and set stored lock to None). - cli/tests/*: Increase various timeouts, add small sleeps, reduce message counts and publisher parallelism, extend deadlines and idle thresholds, and relax exact-equality assertions to tolerate slight losses (use >=95% checks). These changes reduce flakiness in alter-table, subscription, topic, and hot/cold storage smoke tests. - cli/tests/smoke/storage/smoke_test_storage_health.rs: Add wait_for_storage_check_row helper to poll STORAGE CHECK results until a healthy status is observed and replace inline JSON parsing with the helper. - cli/tests/storage/test_hot_cold_storage.rs: Increase query wait timeout, parse flush job id from STORAGE FLUSH output and wait for job completion (with different timeouts in cluster vs local). Overall: tracing correctness and reliability improvements for tests and HTTP tracing; test timing/expectation adjustments to stabilize CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add request tracing improvements and make smoke tests more robust and less flaky.
Overall: tracing correctness and reliability improvements for tests and HTTP tracing; test timing/expectation adjustments to stabilize CI.