Enforce subject-scoped user-table reads#245
Merged
Merged
Conversation
Prevent implicit RLS bypass for user tables by making can_read_all_users always return false and clarifying docs that cross-user access requires explicit impersonation. Update can_access_user_table docs and add unit tests verifying user-table reads never bypass subject scoping. In provider tests, refactor session helper to accept a role, reintroduce session_with_user wrapper, import StringArray, and add integration tests ensuring DBA sessions only see their own rows and deletes produce tombstones scoped to the subject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent implicit RLS bypass for user tables by making can_read_all_users always return false and clarifying docs that cross-user access requires explicit impersonation. Update can_access_user_table docs and add unit tests verifying user-table reads never bypass subject scoping. In provider tests, refactor session helper to accept a role, reintroduce session_with_user wrapper, import StringArray, and add integration tests ensuring DBA sessions only see their own rows and deletes produce tombstones scoped to the subject.